This is not intended behavior - user should be able to sample any feature in the patch. Can you describe in more details what happens in the first case (when using (FeatureType.MASK_TIMELESS, 'SPLIT',))? Is there an exception, feature is not sampled, …?

Thanks.

This class seems to be the problem:

class MoveFeature(EOTask):

    """

    Task to copy fields from one eopatch to another

    The fields are defined as a dictionary in the form {FeatureType: {feature_names_to_copy}}

    """



    def __init__(self, fields_to_copy):

        self.fields_to_copy = fields_to_copy



    def execute(self, *eopatches):



        dst_eopatch, src_eopatch = eopatches

        for key in self.fields_to_copy.keys():

            for name in self.fields_to_copy[key]:

                dst_eopatch.add_feature(key, name, src_eopatch[key][name])

        return dst_eopatch

It refuses to move more than one name of each key type.

I pass:

 move_features = MoveFeature({

    FeatureType.MASK_TIMELESS: {'LULC'},

    FeatureType.MASK_TIMELESS: {'SPLIT'},

    FeatureType.MASK: {'IS_VALID'}})

But the MoveFeature class only picks up FeatureType.MASK_TIMELESS: {'SPLIT'} and FeatureType.MASK: {'IS_VALID'}}).

I can’t figure out why though.

If I use add_feature to manually pass to the new eopatch all the FeatureType I want to erode and sample, it works, which means there is nothing wrong with the PointSamplingTask procedure.

Regards,

William

Hi William,

thanks for providing additional feedback. It looks like MoveFeature task needs some improvement as well.

Anyway, the conceptual issues about the PointSampling task still remain and need to be addressed.

Thanks again for all your feedback,

Anze

Hi William,

In this case the issue is that the dictionary that is passed has multiple fields with the same key. It should work if you pass the following

 move_features = MoveFeature({

    FeatureType.MASK_TIMELESS: {'LULC', 'SPLIT'},

    FeatureType.MASK: {'IS_VALID'}})

The alternative is to use the EOTask._parse_features() method to parse the features to move, instead of looping over keys and names.

Hope this helps.